Auto submodule update: cmake - orion cmake configuration fails when CMAKE_C_COMPILED_ID is not set [OI-1869] (#176) #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot set [OI-1869] ## Jira Ticket https://swift-nav.atlassian.net/browse/OI-1869 ## Bug description orion build fails with ```bash CMake Error at third_party/orion-engine/third_party/auk/cmake/swift_nav/LanguageStandards.cmake:63 (if): if given arguments: "STREQUAL" "IAR" Unknown arguments specified Call Stack (most recent call first): third_party/orion-engine/third_party/auk/cmake/swift_nav/SwiftTargets.cmake:351 (swift_set_language_standards) third_party/orion-engine/third_party/auk/cmake/swift_nav/SwiftTargets.cmake:373 (swift_add_target) proto/CMakeLists.txt:29 (swift_add_library) ``` CMake syntax allows using the variable without ${} to simultaneously check if variable is defined, and variable content. ## Testing Updated `third_party/orion-engine/third_party/auk/cmake/swift_nav/LanguageStandards.cmake` locally with the fix, CMake config runs correctly. Triggered-By: cmake 5b65c03ce8154a2a3a9ae06623849257f87d6dd9 Upstream-PR: http://github.com/swift-nav/cmake/pull/176
armallen
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated PR by Jenkins. If CI has passed successfully, merge away!
cmake 68306be8 -> 5b65c03c
This pull request was created by https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/18075/.