Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Maps from Cross Validation #98

Merged

Conversation

akleeman
Copy link
Collaborator

Cross validation now returns a map from the fold name to a predictions, instead of a vector of predictions. This makes it so we don't need to rely on preserved order.

a predictions, instead of a vector of predictions.  This
makes it so we don't need to rely on preserved order.
@akleeman akleeman requested a review from seth-swiftnav March 26, 2019 23:09
Copy link
Contributor

@seth-swiftnav seth-swiftnav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
I've a small preference for [x] over .at(x) when referencing maps. But as mentioned, that might not be allowed for constant maps.

@akleeman
Copy link
Collaborator Author

yeah, operator [] doesn't work for const maps: https://stackoverflow.com/questions/1474894/why-isnt-the-operator-const-for-stl-maps

@akleeman akleeman merged commit 313c9bf into swift-nav:master Mar 26, 2019
@akleeman akleeman deleted the keep_fold_names_with_cv_predictions branch March 26, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants