Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TEST_SRCS property and swift_add_test_srcs_target macro [BUILD-657] #151

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Add TEST_SRCS property and swift_add_test_srcs_target macro [BUILD-657] #151

merged 3 commits into from
Apr 24, 2023

Conversation

krisukox
Copy link
Contributor

@krisukox krisukox commented Apr 21, 2023 •
edited
Loading

This PR adds:

  • the TEST_SRCS global property, which stores all test source files,
  • the swift_add_test_srcs_target macro, which adds the test_srcs target, which creates the cmake_test_srcs.txt that contains all test source files.

Testing

https://github.com/swift-nav/starling/pull/7881

@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@krisukox krisukox requested a review from jungleraptor April 21, 2023 11:14
jungleraptor
jungleraptor approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@jungleraptor jungleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@krisukox krisukox merged commit b5f4e04 into master Apr 24, 2023
@krisukox krisukox deleted the krisukox/test-srcs-property branch April 24, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jungleraptor jungleraptor jungleraptor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krisukox @jungleraptor