ESD-1959 allow for clang-tidy to be parallized by using the run-clang-tidy scr… #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logingood
reviewed
Feb 26, 2021
RReichert
commented
Feb 26, 2021
| ) | ||
| add_custom_target(clang-tidy-all-check | ||
| COMMAND test ! -f fixes.yaml | ||
| COMMAND test ! -s fixes.yaml |
Contributor
Author
There was a problem hiding this comment.
with run-clang-tidy script, it always produces a fixes.yaml, irrespective of whether or not there is an error, so now it tests to make sure to fail if there a file AND its size is greater than zero.
Contributor
There was a problem hiding this comment.
How long until someone checks in an empty fixes.yaml...? 😄
logingood
approved these changes
Feb 26, 2021
RReichert
changed the title
woodfell
approved these changes
Feb 26, 2021
| set(x_CLANG_TIDY_NAMES | ||
| run-clang-tidy run-clang-tidy.py | ||
| run-clang-tidy-6.0 run-clang-tidy-6.0.py | ||
| run-clang-tidy-4.0 run-clang-tidy-4.0.py |
Contributor
There was a problem hiding this comment.
We can probably just ditch any version other than 6. This is only here fot legacy reasons and lower versions probably won't work properly.
Contributor
Author
|
This PR needed to be removed from master for a couple of reasons:
Anyways the attempt of trying to avoid creating a new function and just piggy back off of the old PR is not working, will need to rewrite the implementation as a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a change to the
clang-tidystage so that it prefers using the parallel script for launching clang-tidy static analysis over using the single threaded approach.