bug-fix: Send safety for sync function #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-kong
commented
Sep 26, 2023
adrian-kong
commented
Sep 26, 2023
adrian-kong
commented
Sep 26, 2023
| } else { | ||
| Err(err.into()) | ||
| let delete_paths_stream = stream.try_filter_map(move |obj| { | ||
| let key = key.to_string(); |
There was a problem hiding this comment.
this ensures Send is satisfied due to &str lifetimes
adrian-kong
commented
Sep 26, 2023
Comment on lines
+643
to
+646
| let s3 = s3.clone(); | ||
| let src_bucket = src_bucket.to_string(); | ||
| let src_prefix = src_prefix.to_string(); | ||
| let dst_prefix = dst_prefix.to_string(); |
There was a problem hiding this comment.
also satisfying Send trait
adrian-kong
commented
Sep 26, 2023
adrian-kong
commented
Oct 1, 2023
| @@ -286,12 +287,12 @@ where | |||
| { | |||
| input_stream.map(move |params| async move { | |||
| let (source_path, metadata) = params?; | |||
| let file_path: Box<dyn AsRef<Path>> = Box::new(source_path.clone()); | |||
| let file_path: Box<dyn AsRef<Path> + Send + Sync> = Box::new(source_path.clone()); | |||
There was a problem hiding this comment.
Adds +Send+Sync to fix passing sync() to thread.
silverjam
approved these changes
Oct 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds send tests and attempts to fix some Send issues
Remaining issues:
1.