Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for message deserialization. #1

Closed
mookerji opened this issue Nov 25, 2014 · 0 comments
Closed

Tests for message deserialization. #1

mookerji opened this issue Nov 25, 2014 · 0 comments
Assignees
@mookerji
Labels
Data Framing/Parsing/IO Message/Code Generation
Milestone
libsbp release

Comments

@mookerji
Copy link
Contributor

Tests are needed, at least for the python client, to check for proper message handling and dispatch.
@mookerji mookerji modified the milestone: Stabilize LibSBP: Cleanup Hacks and Technical Debt Jan 5, 2015
@mookerji mookerji self-assigned this Jan 5, 2015
@mookerji mookerji removed the 5 - Done label Mar 30, 2015
mfine pushed a commit to mfine/libsbp that referenced this issue Oct 28, 2016
@ljbade
Merge pull request swift-nav#1 from JoshuaGross/jgross-track-msg
cd3ed45 
Support 64-bit unsigned ints in the JavaScript version of libsbp.
denniszollo added a commit that referenced this issue Nov 9, 2016
@denniszollo
Merge pull request #1 from JoshuaGross/jgross-fix-dz_sbp_proposal_rebase
a207fc8 
Fix javascript whitelist unit tests for new messages
silverjam pushed a commit that referenced this issue Mar 30, 2021
use binascii instead of plain python [INFRA-404] (#941)
0622d1f 
+ strip out use of use of construct when deframing, this moves construct out of the deframing hot path

+ use binascii (which is a C extension module) to implement the CRC calculation: https://github.com/python/cpython/blob/master/Modules/binascii.c

+ Used sbp2json (skipping the `dispatch` method which parses into fields) to test the speed of just deframing. Speed of deframing (no JSON serializatoin) with master:
```
Benchmark #1: python -m sbp2json <test_data/benchmark.sbp
  Time (mean ± σ):     11.990 s ±  0.331 s    [User: 11.979 s, System: 0.011 s]
  Range (min … max):   11.441 s … 12.556 s    10 runs
```

Speed of deframing (no JSON serialization) with this branch:
```
❯ hyperfine 'python -m sbp2json --include 1 <test_data/benchmark.sbp'                                                                                                                                                (libsbp)
Benchmark #1: python -m sbp2json --include 1 <test_data/benchmark.sbp
  Time (mean ± σ):     961.3 ms ±  18.7 ms    [User: 953.2 ms, System: 8.1 ms]
  Range (min … max):   927.6 ms … 979.2 ms    10 runs
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mookerji mookerji

Labels
Data Framing/Parsing/IO Message/Code Generation
Projects
None yet
Milestone
libsbp release
Development

No branches or pull requests
1 participant
@mookerji