Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing around with JSON serialization. This is pretty broken and not working:
payload
); what really needs to happen is that the json dict from the parent needs to be merged in with the child's json dict. Or some such.from_json
approach here is no bueno with nested structures -json.loads
returns dicts and lists, while the existing objects are built up from construct into containers. Need some kind of json-to-construct mapping function.Thoughts and ideas on how to do a better job here very welcome!
DO NOT MERGE
/cc @mookerji