-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporating final team feedback on specs for release. #108
Conversation
Test PASSed. |
35c83a4
to
b1ef0ab
Compare
Test PASSed. |
b1ef0ab
to
f6efe28
Compare
Test PASSed. |
- Includes clarifying remarks for datasheet copy, as well as documentation for the existing SBP messages. Note that some of the feedback was out-of-scope for this current release, as they'd require some contract changes to existing messages. - A few bug fixes to the latex generation (missing fields and offset error with total message size). /cc @fnoble @denniszollo @mfine
On page 2, have "Note that..." followed by another "Note that..." - make these two paragraphs? |
On page 4 - the underlining in TeX looks a little meh... maybe use italics instead? |
On page 4, we should cancel out the 0 in |
On page 5, what's a "well-survey base station position"? Is that a thing or should it be "well-surveyed" or something? |
On page 18, "File Io" continues to look weird instead of "File IO" |
Looks amazing! Great job! |
For taking out --- a/generator/sbpg/targets/latex.py
+++ b/generator/sbpg/targets/latex.py
@@ -270,7 +270,10 @@ def render_source(output_dir, package_specs):
if multiplier == 1:
adj_size = "N+%d" % (size - 1) if size > 1 else "N"
elif multiplier:
- adj_size = "%dN+%d" % (multiplier, size - multiplier)
+ if multiplier == size:
+ adj_size = "%dN" % multiplier
+ else:
+ adj_size = "%dN+%d" % (multiplier, size - multiplier)
else:
adj_size = "%d" % size
ti = TableItem(pkg_name, d.identifier, d.sbp_id, |
f6efe28
to
a1b197b
Compare
Test PASSed. |
Incorporating final team feedback on specs for release.
documentation for the existing SBP messages. Note that some of the
feedback was out-of-scope for this current release, as they'd
require some contract changes to existing messages.
error with total message size).
/cc @fnoble @denniszollo @mfine