Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporating final team feedback on specs for release. #108

Merged
merged 2 commits into from
Apr 15, 2015

Conversation

mookerji
Copy link
Contributor

  • Includes clarifying remarks for datasheet copy, as well as
    documentation for the existing SBP messages. Note that some of the
    feedback was out-of-scope for this current release, as they'd
    require some contract changes to existing messages.
  • A few bug fixes to the latex generation (missing fields and offset
    error with total message size).

/cc @fnoble @denniszollo @mfine

@mookerji mookerji self-assigned this Apr 15, 2015
@mookerji mookerji added this to the libsbp release milestone Apr 15, 2015
@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/24/
Test PASSed.

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/25/
Test PASSed.

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/26/
Test PASSed.

- Includes clarifying remarks for datasheet copy, as well as
  documentation for the existing SBP messages. Note that some of the
  feedback was out-of-scope for this current release, as they'd
  require some contract changes to existing messages.
- A few bug fixes to the latex generation (missing fields and offset
  error with total message size).

/cc @fnoble @denniszollo @mfine
@mfine
Copy link
Contributor

mfine commented Apr 15, 2015

On page 2, have "Note that..." followed by another "Note that..." - make these two paragraphs?

@mfine
Copy link
Contributor

mfine commented Apr 15, 2015

On page 4 - the underlining in TeX looks a little meh... maybe use italics instead?

@mfine
Copy link
Contributor

mfine commented Apr 15, 2015

On page 4, we should cancel out the 0 in 6N + 0 (I can supply a diff for that)

@mfine
Copy link
Contributor

mfine commented Apr 15, 2015

On page 5, what's a "well-survey base station position"? Is that a thing or should it be "well-surveyed" or something?

@mfine
Copy link
Contributor

mfine commented Apr 15, 2015

On page 18, "File Io" continues to look weird instead of "File IO"

@mfine
Copy link
Contributor

mfine commented Apr 15, 2015

Looks amazing! Great job!

@mfine
Copy link
Contributor

mfine commented Apr 15, 2015

For taking out 6N + 0:

--- a/generator/sbpg/targets/latex.py
+++ b/generator/sbpg/targets/latex.py
@@ -270,7 +270,10 @@ def render_source(output_dir, package_specs):
         if multiplier == 1:
           adj_size = "N+%d" % (size - 1) if size > 1 else "N"
         elif multiplier:
-          adj_size = "%dN+%d" % (multiplier, size - multiplier)
+          if multiplier == size:
+            adj_size = "%dN" % multiplier
+          else:
+            adj_size = "%dN+%d" % (multiplier, size - multiplier)
         else:
           adj_size = "%d" % size
         ti = TableItem(pkg_name, d.identifier, d.sbp_id,

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/27/
Test PASSed.

mookerji added a commit that referenced this pull request Apr 15, 2015
Incorporating final team feedback on specs for release.
@mookerji mookerji merged commit 73c6eb1 into swift-nav:master Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants