Fix Include Paths in Bazel Build #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the include path for when this project is added as an external project in
another workspace.
It is copied into the bazel sandbox at
external/<name>/which doesn'tmatch
-Ic/src/include.I think this is the better option that making the private include path public (copts are not propagated to dependants), but ideally this sort of a workaround wouldn't be
needed.
Have a ticket open to explore alternatives: jira
@swift-nav/devinfra
API compatibility
Does this change introduce a API compatibility risk?
No api risks.