-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crc namespace collision #133
Crc namespace collision #133
Conversation
Test PASSed. |
Ah, ok. Would you mind adding adding a few test cases for the ephemeris in the YAML test data? I can show you an example of how to do that later today: there's a utility in the Python tests directory. The command for doing that is run from the Python client: PYTHONPATH=. python -m tests.sbp.build_test_data -l data/serial_link_log_20150402-100519.log --version 0.29 |
I think we should update the tool to use JSON log iterator as well |
Test FAILed. |
71973c8
to
0eb0190
Compare
Test FAILed. |
0eb0190
to
e7291bd
Compare
Test PASSed. |
Use sbp utils version of walk_json_dict function
both the new and old new ephemeris message
e7291bd
to
682a014
Compare
Test PASSed. |
@mfine @mookerji @cbeighley |
Sweet! |
One second for another look over and I'll go ahead and merge it. |
lgtm, there may be some follow up needed in other modules (piksi_firmware, sbp_log_analysis) as a result of these changes however. |
I am creating an issue in piksi firmware |
The "crc" term in the ephemeris message was colliding with the crc value from the inherited class. This change should avoid the namespace collision by adding an "_" character to each of the amplitude fields. It will break the following:
-- piksi_firmware (when updated to latest libsbp)
-- generated documentation