Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crc namespace collision #133

Merged
merged 4 commits into from
Apr 29, 2015

Conversation

denniszollo
Copy link
Contributor

The "crc" term in the ephemeris message was colliding with the crc value from the inherited class. This change should avoid the namespace collision by adding an "_" character to each of the amplitude fields. It will break the following:
-- piksi_firmware (when updated to latest libsbp)
-- generated documentation

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/81/
Test PASSed.

@mookerji
Copy link
Contributor

Ah, ok. Would you mind adding adding a few test cases for the ephemeris in the YAML test data?

I can show you an example of how to do that later today: there's a utility in the Python tests directory. The command for doing that is run from the Python client:

PYTHONPATH=. python -m tests.sbp.build_test_data -l data/serial_link_log_20150402-100519.log --version 0.29

@denniszollo
Copy link
Contributor Author

I think we should update the tool to use JSON log iterator as well

@swiftnav-jenkins
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/83/
Test FAILed.

@denniszollo denniszollo force-pushed the CRC_namespace_collision branch from 71973c8 to 0eb0190 Compare April 29, 2015 01:32
@swiftnav-jenkins
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/84/
Test FAILed.

@denniszollo denniszollo force-pushed the CRC_namespace_collision branch from 0eb0190 to e7291bd Compare April 29, 2015 16:22
@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/85/
Test PASSed.

Use sbp utils version of walk_json_dict function
both the new and old new ephemeris message
@denniszollo denniszollo force-pushed the CRC_namespace_collision branch from e7291bd to 682a014 Compare April 29, 2015 16:31
@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/86/
Test PASSed.

@denniszollo
Copy link
Contributor Author

@mfine @mookerji @cbeighley
This is ready for review if you anyone has a second.

@mookerji
Copy link
Contributor

Sweet!

@mookerji
Copy link
Contributor

One second for another look over and I'll go ahead and merge it.

mookerji added a commit that referenced this pull request Apr 29, 2015
@mookerji mookerji merged commit 573d3a2 into swift-nav:master Apr 29, 2015
@fnoble
Copy link
Contributor

fnoble commented Apr 29, 2015

lgtm, there may be some follow up needed in other modules (piksi_firmware, sbp_log_analysis) as a result of these changes however.

@denniszollo
Copy link
Contributor Author

I am creating an issue in piksi firmware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants