Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SBP_SENDER_ID: it is not used anywhere and can conflict with user code #1355

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Remove SBP_SENDER_ID: it is not used anywhere and can conflict with user code #1355

merged 1 commit into from
Aug 23, 2023

Conversation

dgburr
Copy link
Contributor

@dgburr dgburr commented Aug 22, 2023

Description

Remove SBP_SENDER_ID since it is not used anywhere and can conflict with user code.

API compatibility

There is no API risk since the define is not used anywhere.

API compatibility plan

N/A

JIRA Reference

N/A

@dgburr dgburr requested a review from a team August 22, 2023 16:13
@dgburr dgburr requested review from silverjam, jungleraptor and a team as code owners August 22, 2023 16:13
@dgburr dgburr merged commit ddbbc2d into master Aug 23, 2023
19 checks passed
@dgburr dgburr deleted the dburr/remove-sbp-sender-id branch August 23, 2023 06:46
@evan-flynn-apexai
Copy link

evan-flynn-apexai commented Jan 24, 2024 •
edited
Loading

@dgburr @woodfell @silverjam looks like the SBP_SENDER_ID is still used in the ROS 2 driver here: https://github.com/swift-nav/swiftnav-ros2/blob/master/test/publishers/test_custom_publishers.cpp#L92

What should be the replacement for SBP_SENDER_ID now that its removed? Just redefine it for that test?

@dgburr
Copy link
Contributor Author

dgburr commented Jan 25, 2024

@evan-flynn-apexai: you should copy the line which was removed (#define SBP_SENDER_ID 0x42) into the ROS 2 driver.

@dgburr dgburr mentioned this pull request Jan 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodfell woodfell woodfell approved these changes

@silverjam silverjam silverjam approved these changes

@jungleraptor jungleraptor Awaiting requested review from jungleraptor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgburr @evan-flynn-apexai @silverjam @woodfell