Run sonar cloud on C/C++ bindings [AP-910] #1374
Conversation
woodfell
force-pushed
the
woodfell/codecov
branch
from
78b92d8 to
d34cc7c
Compare
woodfell
force-pushed
the
woodfell/codecov
branch
from
16bdbed to
df1d621
Compare
|
Note that for some reason the name of the preexisting "auto" sonar cloud stage has changed even though this PR doesn't make any changes. It is now being reported as There is a gate on this stage but since the status is no longer being reported it isn't able to be merged in it's current form. Once the PR is approved I will make the appropriate changes to resolve this issue |
woodfell
requested review from
RReichert,
howardfernandez,
pcrumley and
jungleraptor
There was a problem hiding this comment.
@woodfell ... libsbp had two configs in the safe-settings repo and when we removed the one to unblock you to add the secrets you needed to, we re-enabled that new blocking sonar check which shouldn't be there.
I am merging that fix in shortly and then this PR should be ready to take
|
[libsbp-c] Kudos, SonarCloud Quality Gate passed!
|
Description
@swift-nav/devinfra
Add GA stage to run C/C++ code through sonar cloud
The main sonar cloud stage currently excludes C/C++ code from analysis. Due to the way C/C++ code needs to be processed this stage needs to remain as is.
There is already an extra project in sonar cloud setup up to receive C/C++ but it is currently unused. This PR adds a new stage in GA which runs all the C/C++ unit tests to generate code coverage data, then calls the sonar scanner utility.
Results are posted here as a comment and there is a new status which could be set as a gate on merging PRs (but isn't at the moment)
Code coverage isn't showing up properly on this PR because I accidentally pushed a master analysis to sonar cloud during development of this PR. Since there are no code changes on this PR the diff is 0 and the sonar cloud results are also 0. To test this work I added a new message but didn't create any unit tests. The sonar cloud stage ran properly, detected a couple of code smells and complained about the lack of test coverage. The testing message has since been removed from this branch and is no longer visible.
Results for master can be viewed by going to sonarcloud.io. These results will be the baseline for any future PRs
API compatibility
Does this change introduce a API compatibility risk?
N/A
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
N/A
JIRA Reference
https://swift-nav.atlassian.net/browse/AP-910