Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix new rust lints #1467

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix new rust lints #1467

merged 1 commit into from
Dec 11, 2024

Conversation

pcrumley
Copy link
Contributor

Description

@swift-nav/algint-team -- maybe fixes new rust lints

API compatibility

Does this change introduce a API compatibility risk?

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

JIRA Reference

https://swift-nav.atlassian.net/browse/BOARD-XXXX

@pcrumley pcrumley requested review from notoriaga and a team as code owners December 10, 2024 20:09
@pcrumley pcrumley requested a review from sokhealy December 10, 2024 20:16
Copy link

sonarcloud bot commented Dec 10, 2024

Copy link
Contributor

@sokhealy sokhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for fixing the linting issue!

@pcrumley
Copy link
Contributor Author

@sokhealy can you approve it?

@sokhealy
Copy link
Contributor

@sokhealy can you approve it?

I already did,

@pcrumley pcrumley requested a review from a team December 10, 2024 21:57
Copy link
Contributor

@sokhealy sokhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second approval?

@sokhealy
Copy link
Contributor

I can approve as part of @swift-nav/algint-team , but it looks like it's also waiting for @notoriaga's approval?

@pcrumley
Copy link
Contributor Author

@sokhealy this is silly. I'm just going to bypass branch protections because the change is trivial, and it is failing the macos stage anyway

@pcrumley pcrumley enabled auto-merge (squash) December 11, 2024 00:55
@pcrumley pcrumley disabled auto-merge December 11, 2024 00:55
@pcrumley pcrumley merged commit 1eef842 into master Dec 11, 2024
14 of 15 checks passed
@pcrumley pcrumley deleted the pcrumley/fix-new-rust-lints branch December 11, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants