sbp.client changes for piksi_firmware
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
.... so now might be a good time to figure out a better thread safety story with the context manager. I believe that |
|
Not sure if the problem is going to surface with the context managers, as I'm not super familiar with how contention around that will look like - assume it will be something similar - not sure how you could have multiple threads exiting the same context manager - but are you thinking something like this? master...mfine:mfine-threading-contexts I dug up a lot and couldn't find any great examples of chaining contexts - is there a decorator pattern that will do this or something? |
|
See #65. |
mookerji
added a commit
that referenced
this pull request
Mar 31, 2015
`sbp.client` changes for piksi_firmware
swiftnav-svc-jenkins
pushed a commit
that referenced
this pull request
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes needed to support piksi_firmware for swift-nav/piksi_firmware#295.
/cc @mookerji