Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to fix include guards [AP-243] #122

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Conversation

woodfell
Copy link
Contributor

No description provided.

@woodfell woodfell marked this pull request as ready for review October 20, 2023 04:21
@woodfell woodfell requested a review from a team as a code owner October 20, 2023 04:21
Copy link
Contributor

@jungleraptor jungleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this here Matt.

I just have one small request about the directory layout. I think things are going to get a bit untidy if we just add a new directory for every utility like this (and indeed there are already some "packages" I don't think should be hanging out at the top level).

I was thinking maybe we can put this an a package that lives in cc/tools?:

- cc/
  - tools/
    - BUILD.bazel
    - fix_include_guards.py
    - ...

What do you think about that?

@woodfell
Copy link
Contributor Author

Thanks for adding this here Matt.

I just have one small request about the directory layout. I think things are going to get a bit untidy if we just add a new directory for every utility like this (and indeed there are already some "packages" I don't think should be hanging out at the top level).

I was thinking maybe we can put this an a package that lives in cc/tools?:

- cc/
  - tools/
    - BUILD.bazel
    - fix_include_guards.py
    - ...

What do you think about that?

Works for me

@woodfell woodfell merged commit 32d3699 into main Oct 25, 2023
1 check passed
@woodfell woodfell deleted the woodfell/fix_include_guards branch October 25, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants