Extra string tags to image_stamp_tag, update codeowners[OC-1439] #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
john-michaelburke
commented
Jun 27, 2024
john-michaelburke
commented
- Optionally add a list of extra string tags to either the image_tag or image_stamp_tag output.
- At least for my use case, I would like to use image_stamp_tag to tag not only the git version but add in a "latest-master" tag to the target image.
- I could see value in extending the image_stamp_tag to apply the regex functionality to extra tags, but I'll leave that up to a future user.
- As far as I understand, because I use a default value, this feature should be backwards compatible.
john-michaelburke
changed the title
john-michaelburke
changed the title
pcrumley
approved these changes
Jun 27, 2024
Fortunately any users have to manually uprev rules_swiftnav so I think it is safe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.