Add hedron and extend test suite #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin4861
changed the title
martin4861
force-pushed
the
martin4861/add-hedron
branch
from
071a1bd to
bb6cb49
Compare
martin4861
force-pushed
the
martin4861/add-hedron
branch
from
bb6cb49 to
e4d3161
Compare
sbmueller
approved these changes
Oct 24, 2025
|
|
||
| TEST(BaseMathTest, SignPlus) { | ||
| EXPECT_EQ(Math::sign(10), 1); | ||
| //EXPECT_EQ(Math::sign(-10), -1); |
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
Because I do not want to reach 100% coverage intentionally.
| load("@rules_swiftnav//cc:defs.bzl", "UNIT", "swift_cc_test") | ||
|
|
||
| swift_cc_library( | ||
| cc_library( |
There was a problem hiding this comment.
Why does this not use the swift macro?
There was a problem hiding this comment.
This is to test the behavior of the toolchains, when the normal rules are used (mimic behavior from 3rd party libs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending the existing test suite helps for the upcoming task of refactoring the compile option handling. Also adding hedron compile commands.