-
Notifications
You must be signed in to change notification settings - Fork 0
cc: toolchain: add support for aarch64-darwin-llvm [BUILD-563] #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # https://developer.apple.com/forums/thread/719961 | ||
| "-undefined", | ||
| "dynamic_lookup", | ||
| "-Wl,-no_fixup_chains", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure what chained fixups are but it doesn't seem like we need them, and this silences a bunch of annoying linker warnings.
We do need to build with -undefined dynamic_lookup however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds support for building with the custom llvm toolchain on aarch64-darwin.
Design notes
aarch64-darwin-llvmtoolchain. Thellvm-projectdoes not have prebuilt binaries available for clang-14 on arm macs, so we had to build this distribution from source ourselves: Test m1 mac swift-toolchains#14-ffp-contract=onwhich was made the default in clang-14coreutilsis an implicit dependency since we userealpathin the clang-format scripts.Testing