Hold trace-id in TraceID struct #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2020
ktoso
reviewed
Nov 5, 2020
Tests/W3CTraceContextTests/QueueBasedRandomNumberGenerator.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Nov 5, 2020
ktoso
reviewed
Nov 5, 2020
ktoso
reviewed
Nov 5, 2020
ktoso
reviewed
Nov 5, 2020
ktoso
reviewed
Nov 5, 2020
ktoso
reviewed
Nov 5, 2020
ktoso
approved these changes
Nov 5, 2020
Contributor
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
LGTM :) I think I'd want to add the !-safe comments everywhere tbh, it's noisy but allows us to grep codebases for ! and see if anything is not !-safe annotated
Member
Author
I tend to only "justify" |
Co-authored-by: Konrad `ktoso` Malawski <ktoso@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade trace id from a plain
Stringto its ownTraceIDstruct. This will allow users to make computations, such as comparing the low value to an upper bound (probabilistic sampling).