Enable mutating sampled flag #9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of an effort to enabling mutation of the sampled flag, I refactored
traceParent.traceFlagsto use anOptionSet. Because the W3C Trace Context spec only supportsTraceFlags.sampledat this point,parent.traceFlagscannot be mutated directly. Instead,TraceContextitself now has a get/setsampledproperty that internally retrieves from/writes toparent.traceFlags.When parsing
TraceParentfrom its String representation, anytraceFlagsvalue higher than01will be ignored andtraceFlagsdefault to00(not sampled), as required in the spec: