Skip to content

HTTPRequest without body: Content-Length shall not be send #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

HTTPRequest without body: Content-Length shall not be send #189

wants to merge 1 commit into from

Conversation

fabianfett
Copy link
Member

This pr ensures that we don't send the HTTPHeader Content-Length if we don't have a body.

The RFC states:

The presence of a message-body in a request is signaled by the inclusion of a Content-Length or Transfer-Encoding header field in the request's message-headers.
https://tools.ietf.org/html/rfc2616#section-4.3

@swift-server-bot
Copy link

Can one of the admins verify this patch?

2 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@weissi weissi requested review from artemredkin and Lukasa March 31, 2020 16:05
@weissi
Copy link
Contributor

weissi commented Mar 31, 2020

@swift-server-bot add to whitelist

@artemredkin artemredkin added this to the 1.2.0 milestone Apr 1, 2020
@fabianfett
Copy link
Member Author

close in favor of #191

@fabianfett fabianfett closed this Apr 1, 2020
@fabianfett fabianfett deleted the ff-dont-send-content-length-if-no-body branch April 1, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants