Use a local TCP server that doesn’t accept connections on macOS for testConnectTimeout()
#592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testConnectTimeout()`
|
Swift 5.7 & nightly fails because of |
Lukasa
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed some test failures on our CI where
198.51.100.254accepts connection but it shouldn't.Luckily, this happens only on macOS and we can workaround this by creating a local TCP server with a backlog of
1.This server will only send a
SYN/ACKback to the first connection as it doesn't actually accept the connection. Further connection attempts will not see aSYN/ACK. We can use this behaviour to test a connection timeout on macOS.The backlog behaviour on Linux can not be used to simulate a non-reachable server. Linux sends a
SYN/ACKback even if thebacklogqueue is full as it has two queues. The second queue is not limit byChannelOptions.backlogbut by/proc/sys/net/ipv4/tcp_max_syn_backlog. We will therefore fallback to198.51.100.254on Linux.