-
Notifications
You must be signed in to change notification settings - Fork 125
add NIO event loop as an argument for execute #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5ebd2bd
add NIO event loop as an argument for execute
artemredkin 377b4ef
t pMerge branch 'master' into add_event_loop_in_execute
artemredkin 99fed14
review fix: add to np-delegate method as well
artemredkin 2eefbc7
Merge branch 'master' into add_event_loop_in_execute
artemredkin 61935d7
Merge branch 'master' into add_event_loop_in_execute
artemredkin cd81083
Resolve confict
artemredkin b8ccbd5
add missing linux test
artemredkin 3aea5a2
fix formatting
artemredkin b7078e8
missing self
artemredkin db26532
review fix: add event loop preference argument instead of eventloop
artemredkin 912b5fe
Merge branch 'master' into add_event_loop_in_execute
artemredkin 082cfeb
formatting
artemredkin 3b30918
review fix: spelling
artemredkin 1036075
fix compilation error
artemredkin 1b7e97e
review fixes: make preference argument not explicit and add precondit…
artemredkin 8fa354d
Merge branch 'master' into add_event_loop_in_execute
artemredkin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preference only has one 'r'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, fixed, thanks!