Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addopt strict concurrency #50

Merged
merged 11 commits into from
May 28, 2024
Merged

Conversation

sebsto
Copy link
Contributor

@sebsto sebsto commented May 24, 2024

Adopt StrictConcurrency=complete to prepare fro Swift 6

@sebsto sebsto requested a review from adam-fowler May 24, 2024 09:26
@sebsto
Copy link
Contributor Author

sebsto commented May 24, 2024

5.10 compiles on macOS but not on Linux :-(
I'm investigating why

@sebsto
Copy link
Contributor Author

sebsto commented May 24, 2024

@adam-fowler here is one more. Let me know what you think.
I'm not sure about the DateFormatter change. There might be a performance impact to not use a shared static formatter.

Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

Sources/AWSLambdaEvents/Cloudwatch.swift Outdated Show resolved Hide resolved
Sources/AWSLambdaEvents/Utils/DateWrappers.swift Outdated Show resolved Hide resolved
@sebsto
Copy link
Contributor Author

sebsto commented May 28, 2024

@adam-fowler I implemented the two suggested changes. Thank you for your feedback.
When you have tine, can you give it a new look and approve the merge when you're OK with these.

@sebsto sebsto merged commit 99a3bf1 into swift-server:main May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants