Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup pre Swift 5.6 code #51

Merged
merged 4 commits into from
May 29, 2024

Conversation

sebsto
Copy link
Contributor

@sebsto sebsto commented May 28, 2024

The code base uses pre compiler directives to selectively add Sendable protocol to struct when compiling on Swift >= 5.6

#if swift(>=5.6)
extension XXX: Sendable
#endif

This PR removes this old code and moves all Sendable definitions to the same line as the struct definition.

public struct XXX: Sendable

@sebsto sebsto requested a review from adam-fowler May 28, 2024 09:14
@sebsto sebsto changed the title cleanup pre swift 5.6 code cleanup pre Swift 5.6 code May 28, 2024
Sources/AWSLambdaEvents/CloudFormation.swift Outdated Show resolved Hide resolved
Sources/AWSLambdaEvents/AppSync.swift Outdated Show resolved Hide resolved
@sebsto sebsto self-assigned this May 28, 2024
@sebsto sebsto added the enhancement New feature or request label May 28, 2024
@sebsto sebsto requested a review from adam-fowler May 29, 2024 13:07
Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're good

@sebsto sebsto merged commit 2c04633 into swift-server:main May 29, 2024
5 checks passed
@sebsto sebsto deleted the sebsto/cleanup-pre-swift-56 branch May 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants