Rename payload to event
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fabianfett
force-pushed
the
ff-rename-payload-to-event
branch
from
9cb885e
to
9cf0620
Compare
fabianfett
force-pushed
the
ff-rename-payload-to-event
branch
from
9cf0620
to
bedb7e0
Compare
tomerd
approved these changes
Jun 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of my work in #112. I've moved the branch to my fork though, because of reasons.
Motivation
As @Andrea-Scuderi has correctly pointed out here, we should follow with our naming AWS closely. Currently the inputs name on all our handler protocols is
payload, whereas AWS useseventin nearly all its languages:Only exception:
To ensure general documentation is easier to understand, I would vote that we get in line with AWS, as we did here.
Changes
This pr get's our naming in line with AWS' naming.
payloadtoeventI'm well aware that this is a breaking change. But I think we should get those breaking changes out as soon as possible. The barrier for breaking changes will only increase every day by now.