Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message when invoking local lambda server with incorrect http method #157

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Aug 6, 2020

motivation: nicer error messages

changes: return 405 when using wrong http method on the lambda invocatoin endpoint (local debug server)

… http method

motivation: nicer error messages

changes: return 405 when using wrong http method on the lambda invocatoin endpoint (local debug server)
@tomerd tomerd requested a review from fabianfett August 6, 2020 21:35
@tomerd
Copy link
Contributor Author

tomerd commented Aug 6, 2020

closes #146

@fabianfett @helje5 this is a minimal fix for the most common issue which @helje5 ran into. I agree with @fabianfett idea of addressing more broadly by separating the external facing server and the internal one

@tomerd tomerd linked an issue Aug 6, 2020 that may be closed by this pull request
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomerd
Copy link
Contributor Author

tomerd commented Aug 6, 2020

5.3 failure is due to swift-format, can ignore for now

@tomerd tomerd merged commit f3c68d6 into swift-server:master Aug 6, 2020
@tomerd tomerd added this to the 0.3.0 milestone Aug 6, 2020
@tomerd tomerd added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 on a GET even though resource URL is valid for a POST
2 participants