Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dependency graph and imports #218

Merged
merged 1 commit into from
Aug 13, 2021

Commits on Aug 13, 2021

  1. Clean up dependency graph and imports

    Motivation:
    
    AWSLambdaRuntimeCore and MockServer both have dependencies on the NIO
    module, but they don't express this in their Package.swift: they
    implicitly rely on these dependencies being met by the NIOHTTP1 import.
    This was always brittle: it could lead to timing issues in the build
    that could lead to it failing.
    
    Modifications:
    
    - Correctly express the dependency on NIO in Package.swift
    - Correctly import _NIOConcurrency in files where it's used
    
    Result:
    
    Better and more accurate builds.
    Lukasa committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    6ed1760 View commit details
    Browse the repository at this point in the history