Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit NIO imports #220

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

fabianfett
Copy link
Member

With SwiftNIO 2.32.0, we now have explicit modules for generic NIO structures and the Posix implementations. This PR replaces all usages of import NIO with explicit import of NIOCore and NIOPosix.

@fabianfett fabianfett requested a review from tomerd August 18, 2021 08:15
@fabianfett fabianfett added the 🔼 needs-minor-version-bump For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0 label Aug 18, 2021
@fabianfett fabianfett added this to the 1.0.0-alpha.1 milestone Aug 19, 2021
@fabianfett
Copy link
Member Author

Failing swift-main CI, because of an issue in SwiftNIO - not a blocker: apple/swift-nio#1943

@fabianfett fabianfett merged commit f01a9b6 into swift-server:main Aug 19, 2021
@fabianfett fabianfett deleted the ff-explicit-nio-imports branch August 19, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔼 needs-minor-version-bump For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants