Add default value for traceID header #246
Conversation
|
Can one of the admins verify this patch? |
11 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@swift-server-bot test this please |
|
thanks @StefanNienhuis see feedback inline |
Co-authored-by: tomer doron <tomer@apple.com>
|
@tomerd Sorry for the delay. Should be ready now. |
|
@swift-server-bot test this please |
|
thanks @StefanNienhuis looks like there are some formatting issues the validation script found. you can also run it locally with |
.vscode/launch.json
Outdated
| "preLaunchTask": "swift: Build All" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
I removed it from the commit for now. Do you want me to add it to .gitignore?
| @@ -54,8 +54,7 @@ struct Invocation: Hashable { | |||
| self.requestID = requestID | |||
| self.deadlineInMillisSinceEpoch = unixTimeInMilliseconds | |||
| self.invokedFunctionARN = invokedFunctionARN | |||
| self.traceID = headers.first(name: AmazonHeaders.traceID) ?? | |||
| "Root=\(AmazonHeaders.generateXRayTraceID());Sampled=0" | |||
| self.traceID = headers.first(name: AmazonHeaders.traceID) ?? "Root=\(AmazonHeaders.generateXRayTraceID());Sampled=0" | |||
There was a problem hiding this comment.
should we add a small unit test too so this does not regress?
There was a problem hiding this comment.
As in a test checking the format of the generated traceID?
There was a problem hiding this comment.
testing that we generate a default traceID if no header is provided
There was a problem hiding this comment.
I have that ready. I used the header from another file and changed the year to 2022, but now soundness.sh is complaining that it's not an acceptable year. Should I add s/2022/YEARS/ to the replace_acceptable_years() function?
There was a problem hiding this comment.
Should I add s/2022/YEARS/ to the replace_acceptable_years() function?
yes. sorry about the hassle!
|
@swift-server-bot test this please |
Adds a default value for the Lambda-Runtime-Trace-Id header, to make it compatible with the AWS SAM CLI and other applications depending on the Lambda Runtime Interface Emulator.
Motivation:
Currently the Swift Runtime is incompatible with the Lambda Runtime Interface Emulator.
Modifications:
Adds a default value for the Lambda-Runtime-Trace-Id header.
This is similar to what the Rust runtime is doing.
Result:
The Swift Runtime will be compatible with the Lambda Runtime Interface Emulator.