terminator handler #251
Merged
terminator handler #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabianfett this is still wip but wanted to get an initial feedback on the direction / approach before investing more serious time into this |
tomerd
force-pushed
the
refactor/terminator
branch
from
720911b
to
dee3570
Compare
tomerd
added
🔼 needs-minor-version-bump
tomerd
force-pushed
the
refactor/terminator
branch
from
dee3570
to
0819fa3
Compare
motivation: make it simpler to register shutdown hooks changes: * introduce Terminator helper that allow registering and de-registaring shutdown handlers * expose the new terminator hanler on the InitializationContext and deprecate ShutdownContext * deprecate the Handler::shutdown protocol requirment * update the runtime code to use the new terminator instead of calling shutdown on the handler * add and adjust tests
tomerd
force-pushed
the
refactor/terminator
branch
from
0819fa3
to
8f1c4ff
Compare
yim-lee
reviewed
Mar 21, 2022
Co-authored-by: Yim Lee <yim_lee@apple.com>
tomerd
commented
Mar 21, 2022
tomerd
commented
Mar 21, 2022
yim-lee
approved these changes
Mar 21, 2022
fabianfett
reviewed
Apr 11, 2022
Comment on lines
18
to
21
| extension Lambda { | ||
| /// Lambda terminator. | ||
| /// Utility to manage the lambda shutdown sequence. | ||
| public final class Terminator { |
There was a problem hiding this comment.
I think the Terminator should be Sendable for 5.6 and onwards.
| private var index: [String] | ||
| private var map: [String: (name: String, handler: Terminator.Handler)] | ||
|
|
||
| public init() { |
There was a problem hiding this comment.
Suggested change
| public init() { | |
| init() { |
fabianfett
reviewed
Apr 11, 2022
fabianfett
reviewed
Apr 11, 2022
fabianfett
approved these changes
Apr 13, 2022
| private var index: [String] | ||
| private var map: [String: (name: String, handler: Terminator.Handler)] | ||
|
|
||
| public init() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: make it simpler to register shutdown hooks
changes: