[test] Add a test for cancellable #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
reviewed
Jul 13, 2025
| @@ -50,17 +50,24 @@ struct LambdaRuntimeTests { | |||
| } | |||
|
|
|||
| // wait a small amount to ensure runtime1 task is started | |||
| try await Task.sleep(for: .seconds(0.5)) | |||
There was a problem hiding this comment.
When I run all the tests in parallel this test fails quite regularly as the second task gets run before the first. I don't think you can rely on a sleep to ensure the two tasks are run in order. Maybe you should care which order they run in, just that one throws a LambdaRuntimeError. Do the error check before the taskGroup.next()
await #expect(throws: LambdaRuntimeError.self) {
try await taskGroup.next()
}I'm pretty sure you can get rid of the test that you can run the second runtime after the failure. Is it really valid to have two separate runtimes, run in the the same lambda?
There was a problem hiding this comment.
Thank you for the suggestion. Fixed now.
adam-fowler
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LambdaRuntimefor cancellable.