Make the input HTTPClient required #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
reviewed
Sep 15, 2023
| /// let transport = AsyncHTTPClientTransport() | ||
| /// let httpClient = HTTPClient() | ||
| /// defer { | ||
| /// try! httpClient.syncShutdown() |
There was a problem hiding this comment.
we prefer the async shutdown() method e.g. https://github.com/swift-server/async-http-client/blob/4e74fefd1cc4e747e7989cbe6f125553d3f526e0/Examples/GetJSON/GetJSON.swift#L50
There was a problem hiding this comment.
Oh I'd use that too, but in this example I need to shut down from a defer, and I don't think I can call async functions from there.
There was a problem hiding this comment.
Oh, I didn't see the full example in the unexpanded diff. Yeah, its annoying but that's probably the way to go for this example.
|
Going with this one instead: #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We previously defaulted the HTTPClient to
.init(), but that's not correct as it was never getting shut down.Modifications
Removed the default value, which is a breaking change, so will need to be rolled out with 0.3.0.
Result
No more crashing clients on dealloc.
Test Plan
N/A