Conform ServiceGroup to Service
#172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
approved these changes
Feb 9, 2024
fabianfett
reviewed
Feb 9, 2024
FranzBusch
force-pushed
the
fb-service-service-group
branch
from
d0c7254
to
55810f3
Compare
# Motivation It is possible to nest a `ServiceGroup` inside another `ServiceGroup` however we were missing the conformance to `Service` on the group. # Modification This PR adds the conformance to `Service` to `ServiceGroup`.
FranzBusch
force-pushed
the
fb-service-service-group
branch
from
55810f3
to
b45688a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is possible to nest a
ServiceGroupinside anotherServiceGrouphowever we were missing the conformance toServiceon the group.Modification
This PR adds the conformance to
ServicetoServiceGroup.