Allow mouse down and touch start at any position on the track #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks nice! I will try to release this asap |
|
Thank you! Lots of love to your contributions to this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the end-user first needs to locate a thumb (hover a pointer on it or click somewhere on a track) and then start dragging and scrubbing.
https://gyazo.com/de834e1d5a6ed5d7274255dd66e3bfa5
This PR allows the end-user to start dragging at an arbitrary location within the slider, regardless of the thumb position.
https://gyazo.com/00c080f201988bbd58fab6c4f06306ca
As a side effect of this PR, the
onClickprop, which was useful to detect a click on a track, becomes useless and thus is removed accordingly.