Fix massive memory leak by breaking retain cycle #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any instance of the
GenericKubernetesClient
is never deallocated because there is a retain cycle between the client and itsjsonDecoder
through the date decoding closure which referencesself
. This causes massive memory leak, since everything the client creates, will never be freed from memory (most notably the underlying HTTPClient).My first idea was to use
[unowned self]
to break the retain cycle. But this is only safe if the decoder will never outlive the client instance. Since the decoder is a package internal property we cannot guarantee it. We could make itprivate
, but then we might as well hide the whole date formatting internals. So, this PR just makes the date formatters owned only by the decoder. This breaks the retain cycle.Happy New Year ;)