Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release branch pull request template #2

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

AnthonyLatsis
Copy link
Contributor

@AnthonyLatsis AnthonyLatsis commented Jun 19, 2024

I am not certain that this will work because GitHub is not being crystal clear about pull request templates in particular, but there is no other way to test it. If it does, the template will serve a dual purpose:

  • It will enable us to create pull requests with it in any repository under this org, by using a query parameter: template=release.md
  • It will enable people to propose changes to the form through pull requests, and will be the only source of truth regarding the form.

@AnthonyLatsis
Copy link
Contributor Author

cc @shahmishal

@shahmishal shahmishal merged commit eaae120 into swiftlang:main Jun 20, 2024
@AnthonyLatsis
Copy link
Contributor Author

Woohoo, it works!

@hborla
Copy link
Member

hborla commented Jul 15, 2024

@AnthonyLatsis Thank you for this change!! I used to literally go look up my last release branch cherry pick to swift to copy-paste the template. Very happy that I don't have to do that anymore 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants