Add a soundness check to lint YAML files #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Next time, let’s try to separate formatting and feature work in separate PRs. This makes it easier to review the changes. |
Member
Author
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Oct 4, 2024
In preparation for swiftlang/github-workflows#13
ahoppen
force-pushed
the
yamllint
branch
3 times, most recently
from
a6a8241 to
faf6f28
Compare
ahoppen
commented
Oct 4, 2024
.github/workflows/soundness.yml
Outdated
| type: boolean | ||
| description: "Boolean to enable the YAML lint job. Defaults to true." | ||
| default: true | ||
| yamllint_container_image: |
Member
Author
There was a problem hiding this comment.
@shahmishal Would you like to have a separate option for the base image of yamllint, spellcheck and flake8? Or should all of this be one single options?
FranzBusch
requested changes
Oct 9, 2024
.github/workflows/soundness.yml
Outdated
Comment on lines
193
to
194
| container: | ||
| image: ${{ inputs.yamllint_container_image }} |
Member
There was a problem hiding this comment.
I don't think we need a container image at all here we can just run on the runner itself
.github/workflows/soundness.yml
Outdated
| persist-credentials: false | ||
| - name: Run yamllint | ||
| run: | | ||
| apt-get -qq update && apt-get -qq -y install yamllint |
Member
There was a problem hiding this comment.
The runner itself comes with yamlint preinstalled so we don't have to install it here
Member
|
@FranzBusch, please feel free to merge it once you’ve reviewed it. |
FranzBusch
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.