Add functions to retrieve all tests within a workspace or within a given source file #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
akyrtzi,
benlangmuir and
bnbarham
as code owners
bnbarham
reviewed
Nov 30, 2023
…ven source file This will be used by sourcekit-lsp to discover test.
ahoppen
force-pushed
the
ahoppen/list-tests
branch
from
975848f to
58a64a6
Compare
|
@swift-ci Please test |
|
@swift-ci please test |
bnbarham
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
I'm okay with this in principle, but I do think it would be worth seeing whether we can extend the build system abstraction in sourcekit-lsp to include output paths. That can be something we do later though, since filtering isn't really handled at all today as far as I can tell. We should be filtering the index results on visible output files at minimum though.
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used by sourcekit-lsp to discover test in swiftlang/sourcekit-lsp#978.