Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[lldb][Target] Remove BoundsSafetyTrapFrameRecognizer
`VerboseTrapFrameRecognizer` recognizes `__builtin_verbose_trap` frames, which is used in newer versions of `-fbounds-safety`. This makes `BoundsSafetyTrapFrameRecognizer` redundant. This patch removes it (but makes sure `VerboseTrapFrameRecognizer` still recognizes the old `-fbounds-safety` frame-names). This also fixes the test failure on Swift CI currently we currently incorrectly pick the `BoundsSafetyTrapFrameRecognizer` because the `__builtin_verbose_trap` message contains the string `Bounds check failed`: ``` /Users/ec2-user/jenkins/workspace/oss-lldb-incremental-macos-cmake/llvm-project/lldb/test/Shell/BoundsSafety/boundssafetytrap.test:5:10: error: CHECK: expected string not found in input ^ <stdin>:1:1: note: scanning from here (lldb) command source -s 0 '/Users/ec2-user/jenkins/workspace/oss-lldb-incremental-macos-cmake/build/Ninja-ReleaseAssert+stdlib-Release/lldb-macosx-x86_64/test/Shell/lit-lldb-init-quiet' ^ <stdin>:11:69: note: possible intended match here * thread #1, queue = 'com.apple.main-thread', stop reason = __clang_trap_msg$Bounds check failed$Dereferencing above bounds ^ ``` (cherry picked from commit 837546237c8e1f557ea829aa3dd320e8391e6a22)
- Loading branch information