[lldb] Prevent Task formatter from showing bogus children #10495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
| // Very rarely, the child tasks include a bogus task which has an | ||
| // invalid task id of 0. | ||
| llvm::remove_if(tasks, [&](auto task_ptr) { | ||
| auto task_info = m_reflection_ctx->asyncTaskInfo(task_ptr); |
There was a problem hiding this comment.
just FYI, another pattern to drop an error is llvm::expectedToOptional()
adrian-prantl
approved these changes
Apr 15, 2025
felipepiovezan
requested changes
Apr 15, 2025
|
@swift-ci test |
kastiglione
deleted the
dl/lldb-Prevent-Task-formatter-from-showing-bogus-children
branch
kastiglione
added a commit
that referenced
this pull request
Apr 15, 2025
Very rarely, we've seen a task include a bogus child task. When this has occurred, the task id has been zero, which is invalid. This change filters out a Task's children if they have a task id of 0. (cherry picked from commit 529abca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very rarely, we've seen a task include a bogus child task. When this has occurred, the task id has been zero, which is invalid. This change filters out a Task's children if they have a task id of 0.