[lldb] Fix swift debugging with swift-extra-clang-flags #10620
Merged
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
adrian-prantl
approved these changes
May 5, 2025
I will rebase. Is the LLDB process still fix on release branch and cherry-pick to |
When the ClangImporter in SwiftASTContext is setup with DirectCC1, it wasn't working with `swift-extra-clang-flags` because that will trigger the non DirectCC1 code path only. Make the option working with DirectCC1 mode by directly appending the flag. rdar://150238095
cachemeifyoucan
force-pushed
the
eng/PR-150238095
branch
from
f3ee4f4 to
737c43a
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ClangImporter in SwiftASTContext is setup with DirectCC1, it wasn't working with
swift-extra-clang-flagsbecause that will trigger the non DirectCC1 code path only. Make the option working with DirectCC1 mode by directly appending the flag.rdar://150238095