[6.2] CAS validation improvements (#10966) #10968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
commented
Jul 8, 2025
cachemeifyoucan
commented
- Explanation: Improve the CAS validation to avoid false positives and improve coverage.
- Scope: False positive in CAS validation can cause cache data lost unnecessarily.
- Issues: rdar://155231696
- Original PRs: CAS validation improvements #10966
- Risk: Low. Caching build only. New code has gone through stress tests.
- Testing: CAS validation stress test
- Reviewers: @benlangmuir
* [CAS] Validate upstream CAS storage When asked to validate the CAS, also validate the upstream CAS if present. The entire upstream CAS is available as backup storage of the currently active CAS. If the upstream CAS is corrupted, it can propagate the error into downstream error, thus when upstream CAS is invalid, the entire UnifiedCAS should be invalid. * [CAS] Do not check if action cache value exists in the object store Fix a false positive/crash when validating action cache from unified data base by stop checking the cached value exists in the object store. First of all, there is a bug that the check is always done against primary object store, where the object can be missing. It is also possible that the CAS is in a state where the cache keys are fault in, but not the objects the cache pointed to. There is no good way to enforce it, thus the check is too strict. rdar://155231696 (cherry picked from commit 09bbceb)
Author
|
@swift-ci please test |
akyrtzi
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.