Fix reading the Xcode SDK DWARF attribute from DebugMap symbol files. #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e units When debugging from a SymbolMap the creation of CompileUnits for the individual object files is so lazy that RegisterXcodeSDK() is not invoked at all before the Swift TypeSystem wants to read it. This patch fixes this by introducing an explicit SymbolFile::ParseXcodeSDK() call that can be invoked deterministically before the result is required. <rdar://problem/62532151+62326862> https://reviews.llvm.org/D79273 (cherry picked from commit 5935227) Conflicts: lldb/include/lldb/Core/Module.h
When debugging a remote platform, the platform you get from GetPlatformForArchitecture doesn't inherit from PlatformDarwin. HostInfoMacOSX seems like the right place to have a global store of local paths. Differential Revision: https://reviews.llvm.org/D79364 (cherry picked from commit f0c08b7)
When debugging from a SymbolMap the creation of CompileUnits for the object files is so lazy that RegisterXcodeSDK() is not invoked at all before we need it in SwiftASTContext. This patch fixes this by using the new explicit SymbolFile::ParseXcodeSDK() call that is invoked deterministically before the result is required. This restores macCatalyst support. <rdar://problem/62532151>
|
@swift-ci test |
This was referenced May 6, 2020
|
@swift-ci test |
|
rdar://problem/62677400 |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The also proactively resolves the merge conflict that would be introduced by #1182