[lldb] Add missing nullptr checks to AppleObjCRuntime::GetBacktraceTh… #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…readFromException Summary: We got a few crash reports where LLDB crashes while derefencing the `frames_value` shared_ptr in the AppleObjCRuntime::GetBacktraceThreadFromException. `GetChildMemberWithName` returns a nullptr when an error occurs, so this seems to be just a missing nullptr check. This patch adds that nullptr check and the other ones in the similar code directly below. Fixes rdar://62174039 Reviewers: jingham, kubamracek Reviewed By: jingham Subscribers: abidh, JDevlieghere Differential Revision: https://reviews.llvm.org/D78798 (cherry picked from commit f8af9f5)
|
@swift-ci test |
fredriss
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…readFromException
Summary:
We got a few crash reports where LLDB crashes while derefencing the
frames_valueshared_ptr in the AppleObjCRuntime::GetBacktraceThreadFromException.GetChildMemberWithNamereturns a nullptr when an error occurs, so this seems to be just a missing nullptr check.This patch adds that nullptr check and the other ones in the similar code directly below.
Fixes rdar://62174039
Reviewers: jingham, kubamracek
Reviewed By: jingham
Subscribers: abidh, JDevlieghere
Differential Revision: https://reviews.llvm.org/D78798
(cherry picked from commit f8af9f5)