[LiveDebugValues] Add cutoffs to avoid pathological behavior #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We received a report of LiveDebugValues consuming 25GB+ of RAM when compiling code generated by Unity's IL2CPP scripting backend. There's an initial 5GB spike due to repeatedly copying cached lists of MachineBasicBlocks within the UserValueScopes members of VarLocs. But the larger scaling issue arises due to the fact that prior to range extension, there are 81K basic blocks and 156K DBG_VALUEs: given enough memory, LiveDebugValues would insert 101 million MIs (I counted this by incrementing a counter inside of VarLoc::BuildDbgValue). It seems like LiveDebugValues would have to be rearchitected to support this kind of input (we'd need some new represntation for DBG_VALUEs that get inserted into ~every block via flushPendingLocs). OTOH, large globs of auto-generated code are typically not debugged interactively. So: add cutoffs to disable range extension when the input is too big. I chose the cutoffs experimentally, erring on the conservative side. When compiling a large collection of Apple software, range extension never got disabled. rdar://63418929 Reviewers: aprantl, friss, jmorse, Orlando Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D80662 (cherry picked from commit d11155d)
|
@swift-ci test macOS |
|
Merging in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We received a report of LiveDebugValues consuming 25GB+ of RAM when
compiling code generated by Unity's IL2CPP scripting backend.
There's an initial 5GB spike due to repeatedly copying cached lists of
MachineBasicBlocks within the UserValueScopes members of VarLocs.
But the larger scaling issue arises due to the fact that prior to range
extension, there are 81K basic blocks and 156K DBG_VALUEs: given enough
memory, LiveDebugValues would insert 101 million MIs (I counted this by
incrementing a counter inside of VarLoc::BuildDbgValue).
It seems like LiveDebugValues would have to be rearchitected to support
this kind of input (we'd need some new represntation for DBG_VALUEs that
get inserted into ~every block via flushPendingLocs). OTOH, large globs
of auto-generated code are typically not debugged interactively.
So: add cutoffs to disable range extension when the input is too big. I
chose the cutoffs experimentally, erring on the conservative side. When
compiling a large collection of Apple software, range extension never
got disabled.
rdar://63418929
Reviewers: aprantl, friss, jmorse, Orlando
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D80662
(cherry picked from commit d11155d)