Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the case when a coroutine is dynamically replaceable when targeting older os #1358

Merged

Conversation

aschwaighofer
Copy link

In such a case there will be a call to swift_getFunctionReplacement50 in
the entry block, followed by a call to the replacement function before
the coro.begin. We can safely ignore the call to the replaced function even
though it uses function arguments.

rdar://63804497

…e not dominated by CoroBegin" problem."

This reverts commit efe0093.

rdar://60105794
In such a case there will be a call to swift_getFunctionReplacement in
the entry block, followed by a call to the replacement function before
the coro.begin.

We can safely ignore the call to the replaced function even though it
uses function arguments.

rdar://63001515
…ng older os

In such a case there will be a call to swift_getFunctionReplacement50 in
the entry block, followed by a call to the replacement function before
the coro.begin. We can safely ignore the call to the replaced function even
though it uses function arguments.

rdar://63804497
@aschwaighofer
Copy link
Author

@swift-ci please test

@aschwaighofer aschwaighofer merged commit 6b2bbd2 into swiftlang:apple/stable/20200108 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant