Skip to content

[Swift async] Add a baseline test for arguments and locals in logical frames #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

fredriss
Copy link

@fredriss fredriss commented Mar 8, 2021

No description provided.

@fredriss
Copy link
Author

fredriss commented Mar 8, 2021

@swift-ci please test

@fredriss
Copy link
Author

fredriss commented Mar 8, 2021

We should extend this test with more cases once they work.

@jasonmolenda
Copy link

LGTM. I forgot to add the swiftTest skipIf(oslist=['windows', 'linux']) decorators to the first test I merged this weekend; do we need to skip on linux?

@jasonmolenda
Copy link

(I also thought we needed to tweak the UnwindPlans in the PR I merged Friday night before we could get locals out of the AsyncContext but I didn't check)

@fredriss
Copy link
Author

fredriss commented Mar 8, 2021

(I also thought we needed to tweak the UnwindPlans in the PR I merged Friday night before we could get locals out of the AsyncContext but I didn't check)

The test in its current form just looks at the argument of the live frame. The others don't work. I want to have a test to evolve with the fixes.

@jasonmolenda
Copy link

Last week was a blur. I looked at my test case and I already had those decorators in there.

Copy link

@kastiglione kastiglione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@fredriss fredriss merged commit cf7dfb9 into swiftlang:swift/main Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants