Static analyzer cherrypicks 1#30

Merged

hyp merged 181 commits intoswiftlang:apple/stable/20190619from

haoNoQ:static-analyzer-cherrypicks-1

Oct 26, 2019

Commits on Oct 25, 2019

[analyzer] RetainCount: Add support for OSRequiredCast().
haoNoQ
committed
[analyzer] DeadStores: Add a crude suppression files generated by DriverKit IIG.
haoNoQ
committed
[analyzer] NFC: Change evalCall() to provide a CallEvent.
haoNoQ
committed
[analyzer] Fix JSON dumps for dynamic type information.
haoNoQ
committed
[analyzer] Fix JSON dumps for location contexts.
haoNoQ
committed
[analyzer] Fix JSON dumps for store clusters.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Fix escaping StringRegions.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Implement a --diff mode.
haoNoQ
committed
[analyzer] DeadStores: Update the crude suppression for files generated by IIG.
haoNoQ
committed
[analyzer] Fix JSON dumps for ExplodedNodes

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] print() JSONify: ProgramPoint revision

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] ExprEngine: Escape pointers in bitwise operations

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] Add more timers for performance profiling.
haoNoQ
committed
[analyzer] NFC: exploded-graph-rewriter: Extract some code into functions.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Add support for range constraints.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Fix escaping for bitwise-or.
haoNoQ
committed
[analyzer] print() JSONify: Create pointers

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Prettier location context dumps.
haoNoQ
committed
[analyzer] Fix clang-tidy crash on GCCAsmStmt

nhukc
authored and
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Implement program point tags.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Add support for dynamic types.
haoNoQ
committed
[analyzer] NFC: Add a convenient CallDescriptionMap class.
haoNoQ
committed
[analyzer] NFC: CallDescription: Implement describing C library functions.
haoNoQ
committed
[analyzer] CStringChecker: Modernize to use CallDescriptions.
haoNoQ
committed
[analyzer] NonnullGlobalConstants: Don't be confused by a _Nonnull attribute.
haoNoQ
committed
[analyzer] Fix invalidation when returning into a ctor initializer.
haoNoQ
committed
[analyzer] Support kfree in MallocChecker

nhukc
authored and
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Add support for objects under construction.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Improve program point dumps.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Implement a dark color scheme.
haoNoQ
committed
[IDF] Generalize IDFCalculator to be used with Clang's CFG

Szelethus
authored and
haoNoQ
committed
Removed extra ; after function definition

Szelethus
authored and
haoNoQ
committed
Attempt to fix buildbot failures with MSVC

Szelethus
authored and
haoNoQ
committed
Minor cleanup.

Artem-B
authored and
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Implement checker messages.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Collapse very long statement pretty-prints.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: NFC: Add more comments.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes.
haoNoQ
committed
[Dominators] PR42041: Skip nullpointer successors

Szelethus
authored and
haoNoQ
committed
[analyzer][Dominator] Add post dominators to CFG + a new debug checker

Szelethus
authored and
haoNoQ
committed
Specialize an anchor() function in the correct namespace

Szelethus
authored and
haoNoQ
committed
Make a buildbot using a buggy gcc happy

Szelethus
authored and
haoNoQ
committed
[analyzer][CFG] Return the correct terminator condition

Szelethus
authored and
haoNoQ
committed
Revert "[analyzer][CFG] Return the correct terminator condition"

Szelethus
authored and
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Implement a black-and-white color scheme.
haoNoQ
committed
[analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

Csaba Dabis
authored and
haoNoQ
committed
[CTU] Add support for virtual functions

Gabor Marton
authored and
haoNoQ
committed
[CFG] Add a new function to get the proper condition of a CFGBlock

Szelethus
authored and
haoNoQ
committed
[analyzer][Dominators][NFC] Add unit tests

Szelethus
authored and
haoNoQ
committed
Fix a buildbot failure due to the AST's lifetime ending before the test

Szelethus
authored and
haoNoQ
committed
[analyzer][IDF] Add a control dependency calculator + a new debug checker

Szelethus
authored and
haoNoQ
committed
[analyzer] Track terminator conditions on which a tracked expression depends

Szelethus
authored and
haoNoQ
committed
[analyzer] Add a debug analyzer config to place an event for each tracked condition

Szelethus
authored and
haoNoQ
committed
Removed the test case added in D63538 due to windows buildbot failures

Szelethus
authored and
haoNoQ
committed
[analyzer] Add analyzer option to limit the number of imported TUs

Endre Fulop
authored and
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Implement a single-path mode.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Implement a topology-only mode.
haoNoQ
committed
[analyzer] CastValueChecker: Model casts

Csaba Dabis
authored and
haoNoQ
committed
Revert "[analyzer] CastValueChecker: Model casts"

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] CastValueChecker: Model casts

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] CastValueChecker: Remove a dump()

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Fix filenames in program point.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Improve source location dumps.
haoNoQ
committed
NFC: Unforget a colon in a few CHECK: directives.
haoNoQ
committed
[analyzer] MallocChecker: Prevent Integer Set Library false positives

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] Fix -Wunused-function in NDEBUG builds with #ifdef LLVM_DUMP_METHOD

MaskRay
authored and
haoNoQ
committed
[CrossTU] Added CTU argument to diagnostic consumer create fn.

balazske
authored and
haoNoQ
committed
PlistDiagnostics Fix for compile warning (NFC).

balazske
authored and
haoNoQ
committed
Fix exporting SARIF files from scan-build on Windows.

AaronBallman
authored and
haoNoQ
committed
[CrossTU] Add a function to retrieve original source location.

balazske
authored and
haoNoQ
committed
[CrossTU] Fix plist macro expansion if macro in other file.

balazske
authored and
haoNoQ
committed
Fix failing test plist-macros-with-expansion-ctu.c

balazske
authored and
haoNoQ
committed
[analyzer] Add yaml parser to GenericTaintChecker

boga95
authored and
haoNoQ
committed
Buildbot fix for r367190

boga95
authored and
haoNoQ
committed
Fix taint-generic.c on Windows, handle case in OS error

rnk
authored and
haoNoQ
committed
[analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

Csaba Dabis
authored and
haoNoQ
committed
[Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences

Adam Balogh
authored and
haoNoQ
committed
[analyzer] Fix scan-build's plist output in plist-html mode.
haoNoQ
committed
[analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] CastValueChecker: Model castAs(), getAs()

Csaba Dabis
authored and
haoNoQ
committed
[analyzer][NFC] Refactoring BugReporter.cpp P1.: Store interesting symbols/regions in a simple set

Szelethus
authored and
haoNoQ
committed
[analyzer][NFC] Refactoring BugReporter.cpp P2.: Clean up the construction of bug paths and finding a valid report

Szelethus
authored and
haoNoQ
committed
[analyzer][NFC] Refactoring BugReporter.cpp P3.: std::shared_pointer<PathDiagnosticPiece> -> PathDiagnosticPieceRef

Szelethus
authored and
haoNoQ
committed
[analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it const

Szelethus
authored and
haoNoQ
committed
[analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects

Szelethus
authored and
haoNoQ
committed
[analyzer][NFC] Address inlines of D65484

Szelethus
authored and
haoNoQ
committed
Remove the extra `;`.

darkbuck
authored and
haoNoQ
committed
[analyzer][NFC] Refactoring BugReporter.cpp P6.: Completely get rid of interestingness propagation

Szelethus
authored and
haoNoQ
committed
[analyzer][NFC] Make sure that the BugReport is not modified during the construction of non-visitor pieces

Szelethus
authored and
haoNoQ
committed
[analyzer] Disable the checker-plugins test on Darwin.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Open the converted graph immediately.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: NFC: Refactor explorers into trimmers.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Implement manual graph trimming.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Implement displaying Store pointers.
haoNoQ
committed
[analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus
authored and
haoNoQ
committed
[analyzer] Track the right hand side of the last store regardless of its value

Szelethus
authored and
haoNoQ
committed
[analyzer][NFC] Prepare visitors for different tracking kinds

Szelethus
authored and
haoNoQ
committed
[analyzer] Don't delete TaintConfig copy constructor

bulbazord
authored and
haoNoQ
committed
Fix the -Wunused-variable warning.

hokein
authored and
haoNoQ
committed
[analyzer] Note last writes to a condition only in a nested stackframe

Szelethus
authored and
haoNoQ
committed
[analyzer][CFG] Don't track the condition of asserts

Szelethus
authored and
haoNoQ
committed
[analyzer][NFC] Prove that we only track the evaluated part of the condition

Szelethus
authored and
haoNoQ
committed
[CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock

Szelethus
authored and
haoNoQ
committed
[NFCI] Always initialize BugReport const fields

bulbazord
authored and
haoNoQ
committed
[analyzer] Warn about -analyzer-configs being meant for development purposes only

Szelethus
authored and
haoNoQ
committed
[analyzer] Analysis: Silence checkers

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] Turn an assert into an if condition

Szelethus
authored and
haoNoQ
committed
[analyzer] NFC: Drop support for extra text attached to bug reports.
haoNoQ
committed
[analyzer] NFC: Rename GRBugReporter to PathSensitiveBugReporter.
haoNoQ
committed
[CallGraph] Take into accound calls that aren't within any function bodies.
haoNoQ
committed
[analyzer] Improve VirtualCallChecker and enable parts of it by default.
haoNoQ
committed
[analyzer] Fix a crash when destroying a non-region.
haoNoQ
committed
[analyzer] NFC: Remove the BugTypes set from BugReporter.
haoNoQ
committed
Removed some dead code in BugReporter and related files

gribozavr
authored and
haoNoQ
committed
[analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus
authored and
haoNoQ
committed
[analyzer][NFC] Add different interestingness kinds

Szelethus
authored and
haoNoQ
committed
[analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

Szelethus
authored and
haoNoQ
committed
[analyzer] Mention whether an event is about a condition in a bug report part 2

Szelethus
authored and
haoNoQ
committed
[analyzer] TrackConstraintBRVisitor: Do not track unknown values

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] CastValueChecker: Store the dynamic types and casts

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] CastValueChecker: Rewrite dead header hotfix

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] CastValueChecker: Try to fix the buildbots

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] Don't track the condition of foreach loops

Szelethus
authored and
haoNoQ
committed
[analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] Enable control dependency condition tracking by default

Szelethus
authored and
haoNoQ
committed
Remove an unused function, suppress -Wunused-function warning.

hokein
authored and
haoNoQ
committed
[analyzer] DynamicTypeInfo: Avoid putting null regions into dynamic typemap.
haoNoQ
committed
[analyzer] CastValueChecker: Avoid modeling casts between objects.
haoNoQ
committed
[analyzer] CastValueChecker: Provide DynamicTypeMap with pointer types only.
haoNoQ
committed
[analyzer] CastValueChecker: Correctly model results of based-to-derived casts.
haoNoQ
committed
[analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Kristof Umann
authored and
haoNoQ
committed
[analyzer] Analysis: Fix checker silencing

Csaba Dabis
authored and
haoNoQ
committed
[analyzer] Trust global initializers when analyzing main().
haoNoQ
committed
[analyzer] pr43036: Fix support for operator 'sizeof...'.
haoNoQ
committed
[analyzer] Fix analyzer warnings on analyzer.
haoNoQ
committed
[CFG] Make representation of destructor calls more accurate.
haoNoQ
committed
[analyzer] Fix more analyzer warnings on analyzer and libAnalysis.
haoNoQ
committed
[Analyzer] Iterator Checkers - Make range errors and invalidated access fatal

Adam Balogh
authored and
haoNoQ
committed
[CFG] Fix CFG for statement-expressions in return values.
haoNoQ
committed
[analyzer] Add a checker option to detect nested dead stores

Kristof Umann
authored and
haoNoQ
committed
[analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

Kristof Umann
authored and
haoNoQ
committed
Unbreak the build after r370798

d0k
authored and
haoNoQ
committed
[analyzer] scan-build: handle --sysroot=/path in addition to --sysroot /path.
haoNoQ
committed
[analyzer] pr43179: Make CallDescription defensive against C variadic functions.
haoNoQ
committed
[analyzer] Add minimal support for fix-it hints.
haoNoQ
committed
Move prop-sink branch to monorepo.

boga95
authored and
haoNoQ
committed
[analyzer] NFC: Introduce sub-classes for path-sensitive and basic reports.
haoNoQ
committed
[analyzer] NFC: Simplify bug report equivalence classes to not be ilists.
haoNoQ
committed
[analyzer] NFC: Re-implement stack hints as a side map in BugReport.
haoNoQ
committed
[analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.
haoNoQ
committed
[analyzer] NFC: Move resetDiagnosticLocationToMainFile() to BugReporter.
haoNoQ
committed
[analyzer] NFC: Move PathDiagnostic classes to libAnalysis.
haoNoQ
committed
[analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers

Kristof Umann
authored and
haoNoQ
committed
[analyzer][NFC] Fix inconsistent references to checkers as "checks"

Kristof Umann
authored and
haoNoQ
committed
[ClangTidy] Adjust the name getCheckName to getCheckerName due to API change.

timshen91
authored and
haoNoQ
committed
[CFG] Add dumps for CFGElement and CFGElementRef

Kristof Umann
authored and
haoNoQ
committed
[analyzer] Fix the 'analyzer-enabled-checkers.c' test on non-linux machines.
haoNoQ
committed
Fix a perl warning: Scalar value @ArgParts[0] better written as $ArgParts[0] at /usr/share/clang/scan-build-10/libexec/ccc-analyzer line 502.

sylvestre
authored and
haoNoQ
committed
[analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Kristof Umann
authored and
haoNoQ
committed
[StaticAnalyzer] Use llvm::StringLiteral instead of StringRef in few places

d0k
authored and
haoNoQ
committed
Reland '[analyzer][MallocChecker][NFC] Document and reorganize some functions'

Kristof Umann
authored and
haoNoQ
committed
Fix a documentation error

Kristof Umann
authored and
haoNoQ
committed
Attempt to fix a windows buildbot failure

Kristof Umann
authored and
haoNoQ
committed
[NFCI] Return PathSensitiveBugReport where appropriate

bulbazord
authored and
haoNoQ
committed
[analyzer] Avoid small vectors of non-default-constructibles.
haoNoQ
committed
Don't install example analyzer plugins

aaronpuchert
authored and
haoNoQ
committed
Teach CallGraph to look into Generic Lambdas.

Erich Keane
authored and
haoNoQ
committed
BlockInCriticalSectionChecker - silence static analyzer dyn_cast null dereference warning. NFCI.

RKSimon
authored and
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Make node headers a bit lighter.
haoNoQ
committed
[analyzer] Display cast kinds in program point dumps.
haoNoQ
committed
[analyzer] Assign truly stable identifiers to exploded nodes.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Fix typo in r375186. Unbreaks tests.
haoNoQ
committed
[analyzer] Fix hidden node traversal in exploded graph dumps.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Fix dump for state 0.
haoNoQ
committed
[analyzer] Drop the logic for collapsing the state if it's same as in preds.
haoNoQ
committed
[analyzer] Fix FieldRegion dumps.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Rename Environment to Expressions.
haoNoQ
committed
[analyzer] exploded-graph-rewriter: Unforget to censor stmt_ids in the test.
haoNoQ
committed
[analyzer] Specify the C++ standard in more tests.
haoNoQ
committed
[analyzer] Fix off-by-one in operator call parameter binding.
haoNoQ
committed
Revert "Teach CallGraph to look into Generic Lambdas."
haoNoQ
committed