Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSan] Fix CI test failures #32

Merged
merged 2 commits into from
Oct 26, 2019
Merged

[TSan] Fix CI test failures #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f02efa6
[TSan] Fix CI test failures
yln Jul 17, 2019
52b2ed3
Fixup for "[TSan] Turn on ignore_interceptors_accesses"
yln Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler-rt/test/sanitizer_common/lit.common.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ if config.host_os == 'Darwin':
# On Darwin, we default to `abort_on_error=1`, which would make tests run
# much slower. Let's override this and run lit tests with 'abort_on_error=0'.
default_tool_options += ['abort_on_error=0']
default_tool_options += ['ignore_interceptors_accesses=0']
elif config.android:
# The same as on Darwin, we default to "abort_on_error=1" which slows down
# testing. Also, all existing tests are using "not" instead of "not --crash"
Expand Down
1 change: 1 addition & 0 deletions compiler-rt/test/tsan/Unit/lit.site.cfg.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@ if config.host_os == 'Darwin':
config.environment['TSAN_OPTIONS'] += ':ignore_noninstrumented_modules=0'
else:
config.environment['TSAN_OPTIONS'] = 'ignore_noninstrumented_modules=0'
config.environment['TSAN_OPTIONS'] += ':ignore_interceptors_accesses=0'
1 change: 1 addition & 0 deletions compiler-rt/test/tsan/lit.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ if config.host_os == 'Darwin':
# suppresses some races the tests are supposed to find. Let's run without this
# setting, but turn it back on for Darwin tests (see Darwin/lit.local.cfg).
default_tsan_opts += ':ignore_noninstrumented_modules=0'
default_tsan_opts += ':ignore_interceptors_accesses=0'

# Platform-specific default TSAN_OPTIONS for lit tests.
if default_tsan_opts:
Expand Down